From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 05/10] qede: Add core driver
Date: Wed, 30 Mar 2016 09:45:37 -0700
Message-ID: <20160330094537.024bed45@xeon-e3>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id B4F9A12A8
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:45:21 +0200 (CEST)
Received: by mail-pa0-f41.google.com with SMTP id zm5so45161046pac.0
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:45:21 -0700 (PDT)
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static void
> +qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info *info)
> +{
> +	rte_memcpy(&qdev->dev_info, info, sizeof(*info));

Why bother with rte_memcpy here? why not just assignment or memcpy()?

> +	qdev->num_tc = qdev->dev_info.num_tc;
> +	qdev->ops = qed_ops;
> +}