From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 05/10] qede: Add core driver
Date: Wed, 30 Mar 2016 09:47:57 -0700
Message-ID: <20160330094757.253c012a@xeon-e3>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com
 [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id E3D30293C
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:47:41 +0200 (CEST)
Received: by mail-pf0-f177.google.com with SMTP id x3so47299123pfb.1
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:47:41 -0700 (PDT)
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool action)
> +{
> +	struct ecore_dev *edev = &qdev->edev;
> +	struct qed_update_vport_params params;
> +	int rc;
> +
> +	/* Proceed only if action actually needs to be performed */
> +	if (qdev->accept_any_vlan == action)
> +		return;
> +
> +	memset(&params, 0, sizeof(params));
> +
> +	params.vport_id = 0;
> +	params.accept_any_vlan = action;
> +	params.update_accept_any_vlan_flg = 1;

Minor nit. A lot of this code uses memset() then sets structure elements.
Why not just use C99 style initialization:

	struct qed_update_vport_params params = {
		.vport_id = 0,
		.accept_any_vlan = action,
		.update_accept_any_vlan = 1,
	};