From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 00/10] qede: Add qede PMD Date: Wed, 30 Mar 2016 13:34:12 +0100 Message-ID: <20160330123412.GA22696@bricha3-MOBL3> References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com> <59AF69C657FD0841A61C55336867B5B0359F0E37@IRSMSX103.ger.corp.intel.com> <20160322113007.GA16960@bricha3-MOBL3> <2552F74A0BCCBE4DBE2AD218C81B281108704176@avmb3.qlogic.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "thomas.monjalon@6wind.com" , "dev@dpdk.org" , Ameen Rahman , Harish Patil , Sony Chacko To: Rasesh Mody Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 47CF22BDD for ; Wed, 30 Mar 2016 14:34:18 +0200 (CEST) Content-Disposition: inline In-Reply-To: <2552F74A0BCCBE4DBE2AD218C81B281108704176@avmb3.qlogic.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 29, 2016 at 08:52:38PM +0000, Rasesh Mody wrote: > Hi Bruce, >=20 > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Tuesday, March 22, 2016 4:30 AM > >=20 > > On Tue, Mar 22, 2016 at 11:21:25AM +0000, Richardson, Bruce wrote: > > > I've had a quick scan over this patchset, and as you've probably se= en I've > > made some public comments on it. General comments on the whole > > patchset are: > > > * Please run checkpatch on the patchset and clear up as many issues= as > > > you can. There are a number of typos called out which especially mu= st > > > be fixed. Both myself and Thomas always run checkpatch against patc= hes > > > before applying them. [I suggest using Thomas's checkpatches.sh scr= ipt > > > to do the checks as it disables many unnecessary warnings from > > > checkpatch] > > > * Please put in commit descriptions for all patches bar those doing= trivial > > things. The first three patches probably don't need a commit message,= but > > the rest do. > > > > > > /Bruce > > > > > > > -----Original Message----- > > > > From: Rasesh Mody [mailto:rasesh.mody@qlogic.com] > > > > Sent: Saturday, March 19, 2016 12:53 AM > > > > To: thomas.monjalon@6wind.com; Richardson, Bruce > > > > > > > > Cc: dev@dpdk.org; ameen.rahman@qlogic.com; harish.patil@qlogic.co= m; > > > > sony.chacko@qlogic.com; Rasesh Mody > > > > Subject: [PATCH v3 00/10] qede: Add qede PMD > > > > > > > > Submitting v3 patch series for QEDE PMD. There is no code change > > > > from v2 series except PMD version change. Earlier we had generate= d > > > > and tested the > > > > v2 series against dpdk tree then latest. > > > > > > > > The v3 series includes: > > > > - Patches generated and tested against latest dpdk-next-net > > > > - Reworked MAINTAINERS patch to make it apply cleanly > > > > - Incorporated Overview.rst update in the documentation patch > > > > > > > > Please Apply. > > > > > > > > Thanks! > > > > Rasesh > > > > > > > > Rasesh Mody (10): > > > > qede: Add maintainers > > > > qede: Add documentation > > > > qede: Add license file > > > > qede: Add base driver > > > > qede: Add core driver > > > > qede: Add L2 support > > > > qede: Add SRIOV support > > > > qede: Add attention support > > > > qede: Add DCBX support > > > > qede: Enable PMD build > > > > > > Clang gives a compile error after applying this patchset. Please inve= stigate. > >=20 > > =3D=3D Build drivers/net/qede > > CC base/ecore_dev.o > > fatal error: unknown warning option '-Wno-shift-negative-value'; did = you > > mean > > '-Wno-shift-sign-overflow'? [-Wunknown-warning-option] > > /home/bruce/next-net/dpdk-next-net/mk/internal/rte.compile- > > pre.mk:126: recipe for target 'base/ecore_dev.o' failed > >=20 > > This is seen with clang 3.6 on Fedora 23. > > "clang version 3.6.0 (tags/RELEASE_360/final)" >=20 > We had compiled all our previously submitted driver patches against cla= ng v3.8 on RH7.1 and didn't see a similar error. The '-Wno-shift-negativ= e-value' option got introduced after 3.6.0 release. Pls. let us know if = we need to support a minimum version of clang.=20 > "clang version 3.8.0 (trunk 249596) (llvm/trunk 249595)" > =20 Thanks for the update. I'm not sure that we have a minimum version of cla= ng that we have to support - we tend to test more with gcc than clang. If the lat= est clang version most common distro's compiles this fine, I'd say it's ok. [= The latest on Fedora 23 is actually 3.7, so we are ok with that]. Anyone in the community have a minimum clang version that they need DPDK = to support? > > Similarly, 32-bit (i686) build fails: > >=20 > > =3D=3D Build drivers/net/qede > > CC base/ecore_dev.o > > /home/bruce/next-net/dpdk-next- > > net/drivers/net/qede/base/ecore_dev.c: In function > > =E2=80=98ecore_chain_alloc_sanity_check=E2=80=99: > > /home/bruce/next-net/dpdk-next- > > net/drivers/net/qede/base/ecore_dev.c:2571:32: error: format =E2=80=98= %lx=E2=80=99 > > expects argument of type =E2=80=98long unsigned int=E2=80=99, but arg= ument 6 has type =E2=80=98u64 > > {aka long long unsigned int}=E2=80=99 [-Werror=3Dformat=3D] compilati= on terminated due > > to -Wfatal-errors. > > cc1: all warnings being treated as errors > >=20 > > This is seen with gcc 5.3.1 on Fedora 23. >=20 > For 32-bit, we are preparing our driver to compile against gcc version = 4.3.4. >=20 > Similary, we had compile tested all our previously submitted driver pat= ches on FreeBSD using: > FreeBSD clang version 3.6.1 and > gcc version 4.8.5 Great, thanks. /Bruce >=20 > Thanks! > Rasesh >=20 > > Regards, > > /Bruce