From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] scripts: check commit formatting Date: Wed, 30 Mar 2016 15:27:40 +0100 Message-ID: <20160330142740.GB21156@bricha3-MOBL3> References: <1459286986-31148-1-git-send-email-thomas.monjalon@6wind.com> <20160330014634.GC3080@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , dev@dpdk.org To: Yuanhan Liu Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0D5712BDE for ; Wed, 30 Mar 2016 16:27:51 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160330014634.GC3080@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote: > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > > The git messages have three parts: > > 1/ the headline > > 2/ the explanations > > 3/ the footer tags > > > > The headline helps to quickly browse an history or catch instantly the > > purpose of a commit. Making it short with some consistent wording > > allows to easily parse it or match some patterns. > > > > The explanations must give some keys like the reason of the change. > > Nothing can be automatically checked for this part. > > Actually, I think we might be able to do 2 tests here: > > - space line between paragraphs. > > - lines over 80 chars. 75 chars for commit messages, and 50 for commit titles :-) /Bruce > > --yliu