From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] scripts: check commit formatting
Date: Wed, 30 Mar 2016 15:46:31 +0100
Message-ID: <20160330144631.GD21156@bricha3-MOBL3>
References: <1459286986-31148-1-git-send-email-thomas.monjalon@6wind.com>
 <20160330014634.GC3080@yliu-dev.sh.intel.com>
 <20160330142740.GB21156@bricha3-MOBL3>
 <20160330144414.GD3080@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 789DF2BF9
 for <dev@dpdk.org>; Wed, 30 Mar 2016 16:46:43 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160330144414.GD3080@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 30, 2016 at 10:44:14PM +0800, Yuanhan Liu wrote:
> On Wed, Mar 30, 2016 at 03:27:40PM +0100, Bruce Richardson wrote:
> > On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote:
> > > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote:
> > > > The git messages have three parts:
> > > > 1/ the headline
> > > > 2/ the explanations
> > > > 3/ the footer tags
> > > > 
> > > > The headline helps to quickly browse an history or catch instantly the
> > > > purpose of a commit. Making it short with some consistent wording
> > > > allows to easily parse it or match some patterns.
> > > > 
> > > > The explanations must give some keys like the reason of the change.
> > > > Nothing can be automatically checked for this part.
> > > 
> > > Actually, I think we might be able to do 2 tests here:
> > > 
> > > - space line between paragraphs.
> > > 
> > > - lines over 80 chars.
> > 
> > 75 chars for commit messages, and 50 for commit titles :-)
> 
> I'd agree that 75 char is better. My personal preference is actually
> 68 :) 
> 
I just go with what vim uses on my machine, because vim is always right :-)