From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 05/10] qede: Add core driver
Date: Wed, 30 Mar 2016 15:37:43 -0700
Message-ID: <20160330153743.63605112@xeon-e3>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
 <20160330093926.6bff277c@xeon-e3>
 <D3219CD1.189085%harish.patil@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "dev@dpdk.org"
 <dev@dpdk.org>, Rasesh Mody <rasesh.mody@qlogic.com>
To: Harish Patil <harish.patil@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 186292C3F
 for <dev@dpdk.org>; Thu, 31 Mar 2016 01:55:51 +0200 (CEST)
Received: by mail-pa0-f51.google.com with SMTP id fe3so52168027pab.1
 for <dev@dpdk.org>; Wed, 30 Mar 2016 16:55:51 -0700 (PDT)
In-Reply-To: <D3219CD1.189085%harish.patil@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 30 Mar 2016 22:16:51 +0000
Harish Patil <harish.patil@qlogic.com> wrote:

> >
> >On Tue, 29 Mar 2016 22:28:20 -0700
> >Rasesh Mody <rasesh.mody@qlogic.com> wrote:
> >
> >> +
> >> +static void qede_print_adapter_info(struct qede_dev *qdev)
> >> +{
> >> +	struct ecore_dev *edev = &qdev->edev;
> >> +	struct qed_dev_info *info = &qdev->dev_info.common;
> >> +	char ver_str[QED_DRV_VER_STR_SIZE] = { 0 };
> >> +
> >> +	RTE_LOG(INFO, PMD,
> >> +		  " Chip details : %s%d\n",
> >> +		  ECORE_IS_BB(edev) ? "BB" : "AH",
> >> +		  CHIP_REV_IS_A0(edev) ? 0 : 1);
> >> +
> >> +	sprintf(ver_str, "%s %s_%d.%d.%d.%d", QEDE_PMD_VER_PREFIX,
> >> +		edev->ver_str, QEDE_PMD_VERSION_MAJOR, QEDE_PMD_VERSION_MINOR,
> >> +		QEDE_PMD_VERSION_REVISION, QEDE_PMD_VERSION_PATCH);
> >> +	strcpy(qdev->drv_ver, ver_str);
> >> +	RTE_LOG(INFO, PMD, " Driver version : %s\n", ver_str);
> >> +
> >> +	ver_str[0] = '\0';
> >> +	sprintf(ver_str, "%d.%d.%d.%d", info->fw_major, info->fw_minor,
> >> +		info->fw_rev, info->fw_eng);
> >> +	RTE_LOG(INFO, PMD, " Firmware version : %s\n", ver_str);
> >> +
> >> +	ver_str[0] = '\0';
> >> +	sprintf(ver_str, "%d.%d.%d.%d",
> >> +		(info->mfw_rev >> 24) & 0xff,
> >> +		(info->mfw_rev >> 16) & 0xff,
> >> +		(info->mfw_rev >> 8) & 0xff, (info->mfw_rev) & 0xff);
> >> +	RTE_LOG(INFO, PMD, " Management firmware version : %s\n", ver_str);
> >> +
> >> +	RTE_LOG(INFO, PMD, " Firmware file : %s\n", QEDE_FW_FILE_NAME);
> >
> >This means the driver is far too chatty in the logs.
> >Can't this be made DEBUG level?
> >
> Not clear what is the issue here?
> RTE_LOG is used here to display basic adapter info like firmware/driver
> versions etc without the need to enable any debug flags.
> The driver debug logging is under the control of appropriate debug flags.
> 

The DPDK log messages end up being examined by tech support and customers.
Too much code puts extra stuff in so it is hard to find the real problem.
This is obviously debug info, so either:
  1) make it conditionally compiled
  2) change log level to DEBUG
  3) remove it.