From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v13 0/8] ethdev: 100G and link speed API
 refactoring
Date: Thu, 31 Mar 2016 18:17:19 +0200
Message-ID: <20160331161719.GS27079@6wind.com>
References: <1458934950-23333-1-git-send-email-thomas.monjalon@6wind.com>
 <1458955640-22951-1-git-send-email-marcdevel@gmail.com>
 <2317112.HmzsiIB8a5@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marc Sune <marcdevel@gmail.com>, "Xu, Qian Q" <qian.q.xu@intel.com>,
 "Xing, Beilei" <beilei.xing@intel.com>, dev@dpdk.org,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Glynn, Michael J" <michael.j.glynn@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id B994A93FA
 for <dev@dpdk.org>; Thu, 31 Mar 2016 18:17:37 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id 127so139964200wmu.1
 for <dev@dpdk.org>; Thu, 31 Mar 2016 09:17:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <2317112.HmzsiIB8a5@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Mar 26, 2016 at 09:11:38AM +0100, Thomas Monjalon wrote:
> > v13:
> >     - Fix startup regression; revert flip of ETH_LINK_SPEED_FIXED and
> >       ETH_LINK_SPEED_AUTONEG values. ETH_LINK_SPEED_AUTONEG is now 0.
> 
> As commented earlier, I would prefer avoiding this revert.
> Comments are welcome.

I've tested v13 using testpmd and ixgbe. Performed the following checks:

- Port start/stop - OK, link speed is displayed correctly.
- Forcing 1G / duplex auto - OK.
- Forcing 10G / duplex auto - OK.
- Forcing 10G / duplex half - half is not allowed (expected).
- Forcing 40G / duplex auto - unsupported, causes port start to fail
  (expected). 
- Forcing 1G / duplex full - OK.
- Forcing 100 / duplex half - unsupported, causes port start to fail
  (expected). 
- Forcing 100 / duplex full - OK.
- Traffic flows whenever link speed is supported/negotiated.

Tested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND