From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5 05/10] qede: Add core driver
Date: Fri, 1 Apr 2016 08:41:42 -0700
Message-ID: <20160401084142.11bd9a06@xeon-e3>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
 <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id DD8CF2965
 for <dev@dpdk.org>; Fri,  1 Apr 2016 17:41:28 +0200 (CEST)
Received: by mail-pa0-f46.google.com with SMTP id fe3so93646852pab.1
 for <dev@dpdk.org>; Fri, 01 Apr 2016 08:41:28 -0700 (PDT)
In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 31 Mar 2016 19:15:22 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +struct qed_filter_ucast_params {
> +	enum qed_filter_xcast_params_type type;
> +	uint8_t vlan_valid;
> +	uint16_t vlan;
> +	uint8_t mac_valid;
> +	unsigned char mac[ETHER_ADDR_LEN];
> +} __attribute__ ((__packed__));

Why packed? Why not just rearrange elements to eliminate the padding holes?