From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5 00/10] qede: Add qede PMD
Date: Fri, 1 Apr 2016 08:44:40 -0700
Message-ID: <20160401084440.05f3dcd3@xeon-e3>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 7B43B2965
 for <dev@dpdk.org>; Fri,  1 Apr 2016 17:44:25 +0200 (CEST)
Received: by mail-pa0-f42.google.com with SMTP id td3so93307313pab.2
 for <dev@dpdk.org>; Fri, 01 Apr 2016 08:44:25 -0700 (PDT)
In-Reply-To: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 31 Mar 2016 19:15:17 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> Hi Thomas, Bruce,
> 
> The v5 series incorporates the following review comments:
>  - move adapter_info logs under debug
>  - implement qede_mac_addr_remove()
>  - remove unused rc variable in qede_dev_configure()
>  - fix indentation in qede_dev_info_get()
>  - use c99 style struct init in qede_config_accept_any_vlan()
>  - check error in qede_config_rx_mode()
>  - update overview.rst since patch didn't apply
> 
> The patches are generated and tested against latest dpdk based off of
> v16.04-rc2.
> 
> These patches are checked using checkpatch.sh with following additional
> ignore option:
>    options="$options --ignore=BIT_MACRO,CONCATENATED_STRING"
> 
> Please apply!

Looks good.

One question, is there any restriction on number of Tx queues, relative
to number of Rx queues.  Is it possible to have 8 Tx queues but only 2 Rx queues?
I know bnx2x and some other drivers have that kind of restriction.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>