From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] ixgbe: cleanup whitespace and formatting issues Date: Mon, 4 Apr 2016 18:56:26 -0700 Message-ID: <20160404185626.26c4b1fe@xeon-e3> References: <1459786443-27501-1-git-send-email-stephen@networkplumber.org> <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Zhang, Helin" , "Ananyev, Konstantin" , "dev@dpdk.org" To: "Lu, Wenzhuo" Return-path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 934A5137C for ; Tue, 5 Apr 2016 03:56:15 +0200 (CEST) Received: by mail-pf0-f180.google.com with SMTP id c20so47729554pfc.1 for ; Mon, 04 Apr 2016 18:56:15 -0700 (PDT) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 5 Apr 2016 00:57:16 +0000 "Lu, Wenzhuo" wrote: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 5, 2016 12:14 AM > > To: Zhang, Helin; Ananyev, Konstantin > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues > > > > This driver was one of the originals and has lots of little whitespace issues. > > > > PS: I know Intel doesn't like whitespace changes, there is never a good time > > to do this, but no resuliting binary changes and it is unlikely that more > > changes to this driver will occur this late in release cycle. > > > > Signed-off-by: Stephen Hemminger > Thanks for this patch. I think it's good to make the format better :) > But there's some checkpatch error and warnings, like this, > ERROR: "foo* bar" should be "foo *bar" > #508: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4256: > +ixgbe_uc_hash_table_set(struct rte_eth_dev *dev, struct ether_addr* mac_addr, > I didn't fix all the checkpatch errors, just the easy ones.