From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] virtio: use zeroed memory for simple TX
	header
Date: Tue, 5 Apr 2016 04:05:38 +0800
Message-ID: <20160404200538.GK3080@yliu-dev.sh.intel.com>
References: <1459454476-6029-1-git-send-email-rlane@bigswitch.com>
 <2344074.HmCM8hzj4i@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Rich Lane <rich.lane@bigswitch.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Xie, Huawei" <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D1B1F12A8
 for <dev@dpdk.org>; Mon,  4 Apr 2016 22:04:32 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <2344074.HmCM8hzj4i@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 04, 2016 at 03:13:37PM +0200, Thomas Monjalon wrote:
> Huawei, Yuanhan, any comment?
> 
> 2016-03-31 13:01, Rich Lane:
> >  				vq->vq_ring.desc[i + mid_idx].next = i;
> >  				vq->vq_ring.desc[i + mid_idx].addr =
> > -					vq->virtio_net_hdr_mem +
> > -						i * vq->hw->vtnet_hdr_size;
> > +					vq->virtio_net_hdr_mem;

I could be wrong, but this looks like a special case when i == 0,
which is by no way that zeroed memory is guaranteed? Huawei, do
you have time to check this patch?

Thanks.