From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues Date: Fri, 8 Apr 2016 14:14:58 +0800 Message-ID: <20160408061458.GF3080@yliu-dev.sh.intel.com> References: <1459988946-5956-1-git-send-email-rich.lane@bigswitch.com> <20160407154235.GD3080@yliu-dev.sh.intel.com> <6607494.IC538dk6LI@xps13> <57070D3D.2070700@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , Rich Lane , dev@dpdk.org To: Tetsuya Mukawa Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 903AD2C08 for ; Fri, 8 Apr 2016 08:13:04 +0200 (CEST) Content-Disposition: inline In-Reply-To: <57070D3D.2070700@igel.co.jp> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 08, 2016 at 10:45:33AM +0900, Tetsuya Mukawa wrote: > On 2016/04/08 2:20, Thomas Monjalon wrote: > >>> If the vhost PMD were configured with more queues than the guest, the old > >>> code would segfault in rte_vhost_enable_guest_notification due to a NULL > >>> virtqueue pointer. > >>> > >>> Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > >>> Signed-off-by: Rich Lane > >> Acked-by: Yuanhan Liu > > Applied, thanks > > Hi Rich and Yuanhan, > > I am sorry for late reply. I was out of office yesterday. Tetsuya, no worry! Man takes leaves, and isn't the reason we have 2 or more maintainers on some blocks? :) --yliu > I've tested it also today, and seems to be good. > > Thanks, > Tetsuya