From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4] examples/vm_power_manager: fix libvirt
 dependency check
Date: Mon, 11 Apr 2016 11:37:23 +0100
Message-ID: <20160411103723.GA18468@bricha3-MOBL3>
References: <1460369173-30343-1-git-send-email-yong.liu@intel.com>
 <1460370772-17663-1-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Marvin Liu <yong.liu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 67C342E8A
 for <dev@dpdk.org>; Mon, 11 Apr 2016 12:37:42 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1460370772-17663-1-git-send-email-thomas.monjalon@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 11, 2016 at 12:32:52PM +0200, Thomas Monjalon wrote:
> From: Marvin Liu <yong.liu@intel.com>
>=20
> vm_power_manager utilize libvirt API virDomainGetVcpuPinInfo to
> retrieve domU vcpu information. This API is implemented from version 0.=
9.3.
> Suse11 SP3 32bit default libvirt version is 0.8.8.
>=20
> examples/vm_power_manager/channel_manager.c:
> channel_manager.c:117:3: error: implicit declaration of function
> =E2=80=98virDomainGetVcpuPinInfo=E2=80=99
>=20
> Check and skip it from examples or raise an error when trying to compil=
e
> without libvirt or with a too old libvirt.
>=20
> Fixes: e8ae9b662 ("examples/vm_power: channel manager and monitor in ho=
st")
>=20
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  examples/Makefile                  | 4 ++++
>  examples/vm_power_manager/Makefile | 6 ++++++
>  2 files changed, 10 insertions(+)
>=20
> v4: mix v2 and v3 to skip in examples list but raise an error if trying
>     to compile directly
>=20
Yes, that is the correct way to fix it, I believe.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>