From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 10/10] qede: Enable PMD build Date: Wed, 20 Apr 2016 10:25:03 +0100 Message-ID: <20160420092502.GB4080@bricha3-MOBL3> References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com> <4202835.rtEgrshY1X@xps13> <2411922.nRbcghIYQB@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Harish Patil , Rasesh Mody , dev@dpdk.org, "stephen@networkplumber.org" , Ameen Rahman , Sony Chacko To: Thomas Monjalon Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 321492C37 for ; Wed, 20 Apr 2016 11:25:08 +0200 (CEST) Content-Disposition: inline In-Reply-To: <2411922.nRbcghIYQB@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote: > 2016-04-20 00:14, Harish Patil: > > >2016-03-31 19:15, Rasesh Mody: > > >> --- a/config/common_base > > >> +++ b/config/common_base > > >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=3D24 > > >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=3D48 > > > > > >It looks to be some tuning which could be done at runtime. Isn't it? > > =20 > > That=E2=80=99s right. Can you please suggest if there is any better o= ption to make > > it a runtime? There is no PMD API for that. >=20 > There are some devargs for that. > For PCI dev, it can be passed in the whitelist option. > We should remove this limitation by having a devargs API (and command l= ine > options) independent of whitelisting. But back to the original setting. Are these likely to be values that are = tunable or need to be tunable by the user? If not, I see little reason to make th= em run-time configurable - they could be defines inside the driver itself. /Bruce