From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] eal: fix unchecked return value from library Date: Thu, 21 Apr 2016 09:05:46 -0700 Message-ID: <20160421090546.532b1201@xeon-e3> References: <1461239817-96357-1-git-send-email-danielx.t.mrzyglod@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: anatoly.burakov@intel.com, dev@dpdk.org To: Daniel Mrzyglod Return-path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 295A8CE7 for ; Thu, 21 Apr 2016 18:05:35 +0200 (CEST) Received: by mail-pa0-f44.google.com with SMTP id r5so27567259pag.1 for ; Thu, 21 Apr 2016 09:05:35 -0700 (PDT) In-Reply-To: <1461239817-96357-1-git-send-email-danielx.t.mrzyglod@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Apr 2016 13:56:57 +0200 Daniel Mrzyglod wrote: > + if (setsockopt(conn_sock, SOL_SOCKET, SO_LINGER, &l, sizeof(l)) < 0) > + RTE_LOG(ERR, EAL, "Cannot set SO_LINGER option " > + "on listen socket (%s)\n", strerror(errno)); Priority should be WARNING not ERR because it has no real impact on the application usability level This determines the importance of the message. The levels are, in order of decreasing importance: LOG_EMERG system is unusable LOG_ALERT action must be taken immediately LOG_CRIT critical conditions LOG_ERR error conditions LOG_WARNING warning conditions LOG_NOTICE normal, but significant, condition LOG_INFO informational message LOG_DEBUG debug-level message