From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v3 01/13] e1000: move pci device ids to driver Date: Fri, 22 Apr 2016 08:13:28 -0400 Message-ID: <20160422121328.GA11395@hmsreliant.think-freely.org> References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com> <20160421120835.GA22931@hmsreliant.think-freely.org> <1618846.KqsSDf0vGG@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, David Marchand , Stephen Hemminger , "Richardson, Bruce" , Panu Matilainen , Christian Ehrhardt , Wenzhuo Lu , "Zhang, Helin" To: Thomas Monjalon Return-path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 003142716 for ; Fri, 22 Apr 2016 14:13:41 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1618846.KqsSDf0vGG@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 21, 2016 at 02:41:38PM +0200, Thomas Monjalon wrote: > 2016-04-21 08:08, Neil Horman: > > On Thu, Apr 21, 2016 at 09:27:18AM +0200, David Marchand wrote: > > > I don't mind doing trivial changes, but I don't have time for more on > > > this series. > > > > > Um, I'm not sure what to say here. The whole point of review is to help improve > > the code. If you don't have time to do anything non-trivial, Why are we > > reviewing it? > > Neil, thanks for reviewing. > If David has no time to improve this series, maybe someone else can take over. > I don't see any problem to have several authors on the same series. > Fair point, and yes, I've not done anything toward this goal at all, so I admit some work is better than none. We just can't allow lack of time to be a reason to do something halfway.