From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] i40e: fix problematic dereference
Date: Mon, 25 Apr 2016 10:41:01 +0100
Message-ID: <20160425094100.GA18076@bricha3-MOBL3>
References: <1461210177-29330-1-git-send-email-helin.zhang@intel.com>
 <1461563042-886-1-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Helin Zhang <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 91B6AE07
 for <dev@dpdk.org>; Mon, 25 Apr 2016 11:41:16 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461563042-886-1-git-send-email-helin.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 25, 2016 at 01:44:02PM +0800, Helin Zhang wrote:
> Fix issue reported by Coverity.
> 
> Coverity ID 119267: Dereference before null check.
> Coverity ID 13301: Dereference before null check.
> Coverity ID 13294: Dereference before null check.
> Coverity ID 13299: Dereference before null check.
> Coverity ID 13298: Dereference before null check.

+1 for merging all patches into a single one

> Coverity ID 13265: Missing break in switch.

-1 for sticking in a different fix type into your single patch.

> 
> Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage")
> Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
> Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_pf.c   |  7 +++----
>  drivers/net/i40e/i40e_rxtx.c | 10 +++++++---
>  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> v2:
>  - Combined all the patches into a single one, as suggested.
>  - Remove checking rxq, as it shouldn't be NULL at any time.

Thanks for the V2, but please try and keep the patches logically consistent.
If you have multiple patches fixing the same thing in the one driver, please
keep it in one patch. A fix for a different issue type needs to be in a different
patch. If the fix for one type of issue also causes a second issue of a different
type to be fixed also, please call that out separately in the commit message.
Please also explain how the null checks issues are being fixed, and what the
original issue was.

Regards,
/Bruce