From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v6 2/8] qede: Add base driver
Date: Tue, 26 Apr 2016 14:16:34 +0100
Message-ID: <20160426131634.GC6992@bricha3-MOBL3>
References: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com>
 <1461647586-22234-2-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
 Harish Patil <harish.patil@qlogic.com>,
 Sony Chacko <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 44EED3208
 for <dev@dpdk.org>; Tue, 26 Apr 2016 15:16:38 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461647586-22234-2-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 25, 2016 at 10:13:00PM -0700, Rasesh Mody wrote:
> The base driver is the backend module for the QLogic FastLinQ QL4xxxx
> 25G/40G CNA family of adapters as well as their virtual functions (VF)
> in SR-IOV context.
> 
> The purpose of the base module is to:
>  - provide all the common code that will be shared between the various
>    drivers that would be used with said line of products. Flows such as
>    chip initialization and de-initialization fall under this category.
>  - abstract the protocol-specific HW & FW components, allowing the
>    protocol drivers to have clean APIs, which are detached in its
>    slowpath configuration from the actual Hardware Software Interface(HSI).
> 
> This patch adds a base module without any protocol-specific bits.
> I.e., this adds a basic implementation that almost entirely falls under
> the first category.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---

Checkpatch complains about a few things when I run it, notably this typo:

WARNING:TYPO_SPELLING: 'DIDNT' may be misspelled - perhaps 'DIDN'T'?
#13900: FILE: drivers/net/qede/base/ecore_hsi_tools.h:913:
+       DBG_STATUS_DATA_DIDNT_TRIGGER,

and a few complaints about:

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#223: FILE: drivers/net/qede/base/bcm_osal.c:90:
+       unsigned socket_id;

Regards,
/Bruce