From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Kinzie <ehkinzie@gmail.com>
Subject: Re: [PATCH] bond: inherit maximum rx packet length
Date: Fri, 29 Apr 2016 17:36:42 -0400
Message-ID: <20160429213641.GA30947@roosta.home>
References: <1460654624-2066-1-git-send-email-ehkinzie@gmail.com>
 <571F4849.5030509@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com
 [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id D8C0C39EA
 for <dev@dpdk.org>; Fri, 29 Apr 2016 23:36:44 +0200 (CEST)
Received: by mail-qk0-f193.google.com with SMTP id q184so8969530qkf.0
 for <dev@dpdk.org>; Fri, 29 Apr 2016 14:36:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <571F4849.5030509@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue Apr 26 11:51:53 +0100 2016, Declan Doherty wrote:
> On 14/04/16 18:23, Eric Kinzie wrote:
> >   Instead of a hard-coded maximum receive length, allow the bond interface
> >   to inherit this limit from the first slave added.  This allows
> >   an application that uses jumbo frames to pass realistic values to
> >   rte_eth_dev_configure without causing an error.
> >
> >Signed-off-by: Eric Kinzie <ehkinzie@gmail.com>
> >---
> ...
> >
> 
> Hey Eric, just one small thing, I think it probably makes sense to
> return the max rx pktlen for all slaves, so as we add each slave
> just check if that the slave being value is larger than the current
> value.
> 
> @@ -385,6 +389,10 @@ __eth_bond_slave_add_lock_free(uint8_t
> bonded_port_id, uint8_t slave_port_id)
>                 internals->tx_offload_capa &= dev_info.tx_offload_capa;
>                 internals->flow_type_rss_offloads &=
> dev_info.flow_type_rss_offloads;
> 
> +               /* If new slave's max rx packet size is larger than
> current value then override */
> +               if (dev_info.max_rx_pktlen > internals->max_rx_pktlen)
> +                       internals->max_rx_pktlen = dev_info.max_rx_pktlen;
> +
> 
> Declan

Declan, I sent an updated patch but now release that I mis-read your
comments.  Is it a good idea to change the value once it's been set?
My patch now refuses to add a slave with a pktlen value that's smaller
than that of the first slave.

Eric