From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] nfp: avoiding concurrency when hardware
 reconfig
Date: Tue, 3 May 2016 12:01:49 +0100
Message-ID: <20160503110148.GC20328@bricha3-MOBL3>
References: <1461672855-44715-1-git-send-email-alejandro.lucero@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 06D23590B
 for <dev@dpdk.org>; Tue,  3 May 2016 13:02:07 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461672855-44715-1-git-send-email-alejandro.lucero@netronome.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 26, 2016 at 01:14:15PM +0100, Alejandro Lucero wrote:
> Some apps calling some functions from different threads at the
> same time could lead to reconfig problems. Reconfig mechanism is
> based on a hardware queue where incrementing a counter signals the
> firmware to do the reconfig. If there are two increments before the
> first one has been processed the firmware will stop and a device
> reset is necessary.
>=20
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
>  drivers/net/nfp/nfp_net.c     | 8 ++++++++
>  drivers/net/nfp/nfp_net_pmd.h | 1 +
>  2 files changed, 9 insertions(+)
>=20
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index bc0a3d8..ba0ee04 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -58,6 +58,7 @@
>  #include "nfp_net_pmd.h"
>  #include "nfp_net_logs.h"
>  #include "nfp_net_ctrl.h"
> +#include <rte_spinlock.h>

Hi Alejandro,

I think this header addition is in the wrong place in the code. When I ap=
ply
this patch to next-net and try a recompile I get the error:

  CC nfp_net.o
  In file included from /home/bruce/next-net/dpdk-next-net/drivers/net/nf=
p/nfp_net.c:58:0:
  /home/bruce/next-net/dpdk-next-net/drivers/net/nfp/nfp_net_pmd.h:409:2:=
 error: unknown type name =E2=80=98rte_spinlock_t=E2=80=99
    rte_spinlock_t reconfig_lock;
    ^

You either need to put the spinlock include before the nfp_net_pmd.h incl=
ude
or, perhaps better, put the spinlock include inside the nfp_net_pmd heade=
r file
since that is where the spinlock variable is being defined.

/Bruce