From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] eal: add missing include to debug header
Date: Thu, 5 May 2016 13:59:43 +0100
Message-ID: <20160505125942.GA14228@bricha3-MOBL3>
References: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: thomas.monjalon@6wind.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9656D137D
 for <dev@dpdk.org>; Thu,  5 May 2016 14:59:47 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
> The header file rte_debug.h makes use of the "unlikely" macro which
> means it should include the rte_branch_prediction.h header file.
> 
> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_eal/common/include/rte_debug.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
> index 9260eda..cab6fb4 100644
> --- a/lib/librte_eal/common/include/rte_debug.h
> +++ b/lib/librte_eal/common/include/rte_debug.h
> @@ -44,6 +44,7 @@
>   */
>  
>  #include "rte_log.h"
> +#include "rte_branch_prediction.h"
>  
>  #ifdef __cplusplus
>  extern "C" {

Ping on this patch - any comments or concerns?
It's a fairly trivial fix that prevents issues with testing some other patches
on the mainline.

Regards,
/Bruce