From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 2/3] bnx2x: enhance stats get
Date: Fri, 6 May 2016 15:47:09 +0100
Message-ID: <20160506144709.GC8880@bricha3-MOBL3>
References: <1462340302-25683-1-git-send-email-rasesh.mody@qlogic.com>
 <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com,
 Harish Patil <harish.patil@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A152A5A7A
 for <dev@dpdk.org>; Fri,  6 May 2016 16:47:13 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 03, 2016 at 10:38:21PM -0700, Rasesh Mody wrote:
> Enhance the stats_get() routine to display drop counters under
> imissed counter.
> Added extended stats get support to provide additional info.
> Encorporated review comment to rename some of the stats.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>

Again this seems to me like it should be two patches rather than one. A first
patch as a fix for the drop counters and then a second patch to add the xstats
functionality.

Regards,
/Bruce