From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 02/20] thunderx/nicvf: add pmd skeleton Date: Tue, 10 May 2016 12:55:28 +0530 Message-ID: <20160510072527.GA18442@localhost.localdomain> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-3-git-send-email-jerin.jacob@caviumnetworks.com> <20160509104122.5c65f12a@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , , , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki To: Stephen Hemminger Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0097.outbound.protection.outlook.com [65.55.169.97]) by dpdk.org (Postfix) with ESMTP id C193B8D95 for ; Tue, 10 May 2016 09:25:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160509104122.5c65f12a@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 09, 2016 at 10:41:22AM -0700, Stephen Hemminger wrote: > On Sat, 7 May 2016 20:46:20 +0530 > Jerin Jacob wrote: > > > + > > +static inline struct nicvf* > > +nicvf_pmd_priv(struct rte_eth_dev *eth_dev) > > +{ > > + return (struct nicvf *)eth_dev->data->dev_private; > > +} > > Cast here is unnecessary because dev_private is void * Agree with all of your review comments in [PATCH 01/20] and [PATCH 02/20]. Will fix it in V2.