From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [PATCH 11/15] vfio: move global vfio_cfg to
	eal_vfio.c
Date: Tue, 10 May 2016 14:55:43 +0200
Message-ID: <20160510145543.034ce747@jvn>
References: <1461937456-22943-1-git-send-email-viktorin@rehivetech.com>
 <1461937456-22943-12-git-send-email-viktorin@rehivetech.com>
 <C6ECDF3AB251BE4894318F4E451236978210B7FA@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, David Marchand
 <david.marchand@6wind.com>, "Wiles, Keith" <keith.wiles@intel.com>, Santosh
 Shukla <sshukla@mvista.com>, "Stephen Hemminger"
 <stephen@networkplumber.org>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15])
 by dpdk.org (Postfix) with ESMTP id 0C1A59AF0
 for <dev@dpdk.org>; Tue, 10 May 2016 14:55:40 +0200 (CEST)
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236978210B7FA@IRSMSX109.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 10 May 2016 11:56:36 +0000
"Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:

> Hi Jan,
> 
> > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> > @@ -39,10 +39,282 @@
> >  #include <rte_log.h>
> >  #include <rte_memory.h>
> >  #include <rte_eal_memconfig.h>
> > +#include <eal_private.h>
> > 
> >  #include "eal_filesystem.h"
> >  #include "eal_vfio.h"  
> 
> I believe the eal_private.h should be local include (in quotes), like in other places.

+1

> 
> > +/**
> > + * Setup vfio_cfg for the device indentified by its address. It
> > +discovers
> > + * the configured I/O MMU groups or sets a new one for the device. If a
> > +new
> > + * groups is assigned, the DMA mapping is performed.
> > + * Returns 0 on success, a negative value on failure and a positive
> > +value in
> > + * case the given device cannot be managed this way.
> > + */  
> 
> I think it would've been good to fix the typo in the comment ("indentified") :)

Ok.

Regards
Jan

> 
> Thanks,
> Anatoly



-- 
  Jan Viktorin                E-mail: Viktorin@RehiveTech.com
  System Architect            Web:    www.RehiveTech.com
  RehiveTech
  Brno, Czech Republic