From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCHv2 1/4] pmdinfogen: Add buildtools and
	pmdinfogen utility
Date: Thu, 19 May 2016 08:00:56 -0400
Message-ID: <20160519120056.GD4128@hmsreliant.think-freely.org>
References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com>
 <1463605687-649-1-git-send-email-nhorman@tuxdriver.com>
 <1463605687-649-2-git-send-email-nhorman@tuxdriver.com>
 <81cef5e5-3220-710f-aebf-a703c1423199@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id EE13F5A5A
 for <dev@dpdk.org>; Thu, 19 May 2016 14:01:07 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <81cef5e5-3220-710f-aebf-a703c1423199@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, May 19, 2016 at 10:51:19AM +0300, Panu Matilainen wrote:
> On 05/19/2016 12:08 AM, Neil Horman wrote:
> [...]
> > +		if (strcmp(secname, ".modinfo") == 0) {
> > +			if (nobits)
> > +				fprintf(stderr, "%s has NOBITS .modinfo\n", filename);
> > +			info->modinfo = (void *)hdr + sechdrs[i].sh_offset;
> > +			info->modinfo_len = sechdrs[i].sh_size;
> > +		} else if (strcmp(secname, "__ksymtab") == 0)
> > +			info->export_sec = i;
> > +		else if (strcmp(secname, "__ksymtab_unused") == 0)
> > +			info->export_unused_sec = i;
> > +		else if (strcmp(secname, "__ksymtab_gpl") == 0)
> > +			info->export_gpl_sec = i;
> > +		else if (strcmp(secname, "__ksymtab_unused_gpl") == 0)
> > +			info->export_unused_gpl_sec = i;
> > +		else if (strcmp(secname, "__ksymtab_gpl_future") == 0)
> > +			info->export_gpl_future_sec = i;
> > +
> 
> Looks like a leftover from kernel modpost.c, not needed in DPDK.
> 
> 	- Panu -
> 
Yup, I'll remove it
Neil