From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 05/40] bnxt: add dev configure operation
Date: Wed, 25 May 2016 16:25:55 +0100
Message-ID: <20160525152555.GD12776@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-5-git-send-email-stephen.hurd@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Stephen Hurd <stephen.hurd@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 096CE388F
 for <dev@dpdk.org>; Wed, 25 May 2016 17:25:58 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1463179589-82681-5-git-send-email-stephen.hurd@broadcom.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 13, 2016 at 03:45:54PM -0700, Stephen Hurd wrote:
> This adds the bnxt_hwrm_port_phy_cfg() HWRM call, and copies required
> information into the new struct bnxt_link_info.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt.h                |  32 +++
>  drivers/net/bnxt/bnxt_ethdev.c         |  24 ++
>  drivers/net/bnxt/bnxt_hwrm.c           | 232 +++++++++++++++-
>  drivers/net/bnxt/bnxt_hwrm.h           |   1 +
>  drivers/net/bnxt/hsi_struct_def_dpdk.h | 470 +++++++++++++++++++++++++++++++++
>  5 files changed, 758 insertions(+), 1 deletion(-)
> 

Again, a minor issue: checkpatch flags a couple of instances of "unsigned" instead of 
"unsigned int" in this patch. Maybe just scan the rest of the set with checkpatch
to pick up on other minor niggles like this.

/Bruce