From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 08/40] bnxt: add completion ring support
Date: Thu, 26 May 2016 10:38:00 +0100
Message-ID: <20160526093800.GC11928@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-8-git-send-email-stephen.hurd@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Stephen Hurd <stephen.hurd@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 3AA282BDF
 for <dev@dpdk.org>; Thu, 26 May 2016 11:38:03 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1463179589-82681-8-git-send-email-stephen.hurd@broadcom.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 13, 2016 at 03:45:57PM -0700, Stephen Hurd wrote:
> Structures, macros, and functions for working with completion rings
> in the driver.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/Makefile              |   1 +
>  drivers/net/bnxt/bnxt.h                |   6 +
>  drivers/net/bnxt/bnxt_cpr.c            | 139 +++++++++++++++++++
>  drivers/net/bnxt/bnxt_cpr.h            |  88 ++++++++++++
>  drivers/net/bnxt/bnxt_hwrm.c           |  18 +++
>  drivers/net/bnxt/bnxt_hwrm.h           |   2 +
>  drivers/net/bnxt/hsi_struct_def_dpdk.h | 239 ++++++++++++++++++++++++++++++++-
>  7 files changed, 487 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/net/bnxt/bnxt_cpr.c
>  create mode 100644 drivers/net/bnxt/bnxt_cpr.h
> 
> diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile
> index 757ea62..afd1690 100644
> --- a/drivers/net/bnxt/Makefile
> +++ b/drivers/net/bnxt/Makefile
> @@ -48,6 +48,7 @@ EXPORT_MAP := rte_pmd_bnxt_version.map
>  #
>  # all source are stored in SRCS-y
>  #
> +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_cpr.c
>  SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_ethdev.c
>  SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_hwrm.c
>  SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_ring.c
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index 846972e..4e0b514 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -42,6 +42,9 @@
>  #include <rte_lcore.h>
>  #include <rte_spinlock.h>
>  
> +/* TODO make bnxt.def_cp_ring a pointer to avoid this... */
> +#include "bnxt_cpr.h"
> +

I see this TODO is fixed a couple of patches later. Can we get the fix
included in this patch so that the TODO never appears?

/Bruce