From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2 24/40] bnxt: add HWRM ring alloc/free functions Date: Thu, 26 May 2016 14:19:43 +0100 Message-ID: <20160526131943.GH7708@bricha3-MOBL3> References: <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com> <1463179589-82681-24-git-send-email-stephen.hurd@broadcom.com> <20160526124555.GF7708@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Stephen Hurd Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4497937B2 for ; Thu, 26 May 2016 15:19:47 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160526124555.GF7708@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 26, 2016 at 01:45:55PM +0100, Bruce Richardson wrote: > On Fri, May 13, 2016 at 03:46:13PM -0700, Stephen Hurd wrote: > > Add HWRM calls to allocate and free TX/RX/CMPL rings along with > > the associated structs and definitions. > > > What are these RX/TX/CMPL rings used for? I assume they are different from the > RX/TX rings used to send/receive packets, or am I missing something? > > Also, I see some compilation errors after applying this patch in the series. > gcc gives errors about "struct bnxt_ring_struct declared inside parameter list". > I see a fix for this is made in patch 27, which is good. I just suggest squashing that patch into this one. /Bruce