From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 31/40] bnxt: add start/stop/link update
	operations
Date: Thu, 26 May 2016 14:46:11 +0100
Message-ID: <20160526134611.GL7708@bricha3-MOBL3>
References: <9c8bee$sshbeq@fmsmga001.fm.intel.com>
 <1463603381-89710-1-git-send-email-stephen.hurd@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, sys_stv@intel.com
To: Stephen Hurd <stephen.hurd@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id C91834B79
 for <dev@dpdk.org>; Thu, 26 May 2016 15:46:43 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1463603381-89710-1-git-send-email-stephen.hurd@broadcom.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 18, 2016 at 01:29:41PM -0700, Stephen Hurd wrote:
> BNXT driver will now minimally pass traffic with testpmd.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 267 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 267 insertions(+)
>
<snip>
> +	memset(&new, 0, sizeof(new));
> +	do {
> +		/* Retrieve link info from hardware */
> +		rc = bnxt_get_hwrm_link_config(bp, &new);
> +		if (rc) {
> +			new.link_speed = ETH_LINK_SPEED_100M;
> +			new.link_duplex = ETH_LINK_FULL_DUPLEX;
> +			RTE_LOG(ERR, PMD,
> +				"Failed to retrieve link rc = 0x%d!", rc);

Checkpatch correctly flags this as an error. If you put 0x in front of a number
the output format needs to be %x rather than %d.

/Bruce