From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] virtio: use volatile to get used->idx in the
 loop
Date: Wed, 1 Jun 2016 14:05:32 +0800
Message-ID: <20160601060532.GK5641@yliu-dev.sh.intel.com>
References: <1464106601-981-1-git-send-email-huawei.xie@intel.com>
 <20160530082258.GF5641@yliu-dev.sh.intel.com>
 <C37D651A908B024F974696C65296B57B4C7C00DB@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 58842379B
 for <dev@dpdk.org>; Wed,  1 Jun 2016 08:02:42 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <C37D651A908B024F974696C65296B57B4C7C00DB@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 01, 2016 at 05:40:08AM +0000, Xie, Huawei wrote:
> On 5/30/2016 4:20 PM, Yuanhan Liu wrote:
> > On Wed, May 25, 2016 at 12:16:41AM +0800, Huawei Xie wrote:
> >> There is no external function call or any barrier in the loop,
> >> the used->idx would only be retrieved once.
> >>
> >> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> >> ---
> >>  drivers/net/virtio/virtio_ethdev.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> >> index c3fb628..f6d6305 100644
> >> --- a/drivers/net/virtio/virtio_ethdev.c
> >> +++ b/drivers/net/virtio/virtio_ethdev.c
> >> @@ -204,7 +204,8 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
> >>  		usleep(100);
> >>  	}
> >>  
> >> -	while (vq->vq_used_cons_idx != vq->vq_ring.used->idx) {
> >> +	while (vq->vq_used_cons_idx !=
> >> +	       *((volatile uint16_t *)(&vq->vq_ring.used->idx))) {
> > I'm wondering maybe we could fix VIRTQUEUE_NUSED (which has no such
> > qualifier) and use this macro here?
> >
> > If you check the reference of that macro, you might find similar
> > issues, say, it is also used inside the while-loop of
> > virtio_recv_mergeable_pkts().
> >
> > 	--yliu
> >  
> >
> 
> Yes, seems it has same issue though haven't confirmed with asm code.

So, move the "volatile" qualifier to VIRTQUEUE_NUSED?

	--yliu