From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] scripts: check commits with checkpatch Date: Thu, 2 Jun 2016 14:23:57 +0100 Message-ID: <20160602132356.GA8880@bricha3-MOBL3> References: <1464858795-3152-1-git-send-email-thomas.monjalon@6wind.com> <20160602123337.GA14836@bricha3-MOBL3> <3747156.fc7lGR2aaH@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 006F05937 for ; Thu, 2 Jun 2016 15:37:58 +0200 (CEST) Content-Disposition: inline In-Reply-To: <3747156.fc7lGR2aaH@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 02, 2016 at 03:15:54PM +0200, Thomas Monjalon wrote: > 2016-06-02 13:33, Bruce Richardson: > > Testing this out here, I find that git format-patch includes the diff stats > > in the output, which then can trigger long-line warnings for the commit message. > > > > WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) > > #8: > > examples/my-new-test-app/basicfwd.c | 342 +++++++++++++++++++++++++++++++++++++ > > > > To fix this, I suggest replacing "format-patch --stdout" with "show --format=email" > > since that should give the same output just without the change stats. > > or format-patch --no-stat > Sure, whatever works! :-) It's just a longer command :-) /Bruce