From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] doc: add pep8 as the python code style guidelines Date: Fri, 3 Jun 2016 11:51:33 +0100 Message-ID: <20160603105133.GA17812@bricha3-MOBL3> References: <1464361035-4087-1-git-send-email-john.mcnamara@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: John McNamara Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 93FE32B8A for ; Fri, 3 Jun 2016 12:51:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1464361035-4087-1-git-send-email-john.mcnamara@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 27, 2016 at 03:57:15PM +0100, John McNamara wrote: > Added PEP8 to the DPDK Coding Style guidelines to cover Python > contributions to DPDK. > > Signed-off-by: John McNamara > --- > v2: fixed section level. > > > doc/guides/contributing/coding_style.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > index ad1392d..1eb67f3 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -685,3 +685,11 @@ Control Statements > usage(); > /* NOTREACHED */ > } > + > + > +Python Code > +----------- > + > +All python code should be compliant with `PEP8 (Style Guide for Python Code) `_. > + > +The ``pep8`` tool can be used for testing compliance with the guidelines. > -- Yep, I think this would be good to have, especially since there is a nice public tool to help ensure people are compliant with this. Even though all existing code is not (yet) compliant no reason new code shouldn't be. Acked-by: Bruce Richardson