From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Hall <mhall@mhcomputing.net>
Subject: Re: [RFC] Yet another option for DPDK options
Date: Fri, 3 Jun 2016 14:41:37 -0700
Message-ID: <20160603214137.GC16022@mhcomputing.net>
References: <f7262fa6-220e-0050-1a06-b046ab9009df@redhat.com>
 <CAKy9EB3ca+nufggexRogY3TOU=LMdf1dRFJSPxhmdrdyW2fc6A@mail.gmail.com>
 <8CE01283-1E89-4302-BE7D-486975B43EF6@intel.com>
 <20160603174437.GC12627@hmsreliant.think-freely.org>
 <62A67FEB-AE18-43B1-8D15-27F23D5C8A7D@intel.com>
 <20160603183819.GD12627@hmsreliant.think-freely.org>
 <CAKy9EB2imz7S6h_UY2U9_V9iU5mvncfQRb3RGs+Uz9+ct5_10Q@mail.gmail.com>
 <DC0EC027-2812-4D4F-A757-AB737999ACD4@intel.com>
 <AA73B345-1FBD-44CE-BD93-8B85D8DC9650@intel.com>
 <20160603191804.GE12627@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Wiles, Keith" <keith.wiles@intel.com>, Arnon Warshavsky <arnon@qwilt.com>,
 Panu Matilainen <pmatilai@redhat.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 Olivier Matz <olivier.matz@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170])
 by dpdk.org (Postfix) with ESMTP id 7B4FA5902
 for <dev@dpdk.org>; Fri,  3 Jun 2016 23:41:38 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160603191804.GE12627@hmsreliant.think-freely.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 03, 2016 at 03:18:04PM -0400, Neil Horman wrote:
> I'm not opposed to default values, but it seems to me that if we are splitting
> out a configuration storage library from dpdk, part of the initzliation of that
> library can be installing default values.  That is to say, instead of having the
> code specific areas assume a default value if none is present in the config, an
> init function for the configuration storage library would just populate the
> keystore.  That way all the dpdk itself has to do is a key lookup.
> 
> Neil

I don't think this provides as much mental locality of reference for people 
reading the code. But, an unwanted default argument can be filled with 0 / 
NULL / false as needed.

Matthew.