From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] scripts: add script for generating
 customised build config
Date: Tue, 7 Jun 2016 10:25:57 +0100
Message-ID: <20160607092556.GA15536@bricha3-MOBL3>
References: <1461061640-7611-1-git-send-email-bruce.richardson@intel.com>
 <1461944891-7280-1-git-send-email-bruce.richardson@intel.com>
 <6235932.qgKH91Itup@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id AA09D6A80
 for <dev@dpdk.org>; Tue,  7 Jun 2016 11:26:21 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <6235932.qgKH91Itup@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 07, 2016 at 09:36:37AM +0200, Thomas Monjalon wrote:
> Hi Bruce
> 
> 2016-04-29 16:48, Bruce Richardson:
> > This patch adds in the configure.py script file. It can be used to
> > generate custom build-time configurations for DPDK either manually on
> > the commandline or by calling it from other scripts. It takes as parameters
> > the base config template to use, and output directory to which the modified
> > configuration will be written. Other optional parameters are then taken
> > as y/n values which should be adjusted in the config file, and a special
> > -m flag is provided to override the default RTE_MACHINE setting in the
> > config template too.
> 
> You were planning to use this script but not make it the official way of
> building DPDK. I think it should be the official way.
> I would suggest to integrate it quietly and improve it to make it more
> official later.
> What do you think is missing in the current design to take it as a base
> for later work?
> I really would like to see the dependencies (internal and external)
> managed in this script.
> 

I agree, we can look to add that in future.

> [...]
> > +-m, --machine-type=TYPE
> > +    Override the machine-type value given in the default configuration by
> > +    setting it to TYPE. Using regular options, regular y/n values can be
> > +    changed, but not string options, so this explicit override for machine
> > +    type exists to allow changing it.
> 
> I think we should make possible to change string values as boolean ones in
> a generic way.
> 

Yes. I just didn't implement this before since there are so few string values 
in our config, and I didn't think it was that useful apart from machine type. If
in future, we will use this script as the official configuration method, then
it does need to be added.

> Detail: the MAINTAINERS file must be updated for this new file.

Yep.

/Bruce