From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] mk: generate internal library dependencies from DEPDIRS-y automatically Date: Tue, 7 Jun 2016 15:37:54 +0100 Message-ID: <20160607143754.GA11964@bricha3-MOBL3> References: <62da0f5f31b2ab9db2dcc16acd2f8425a575a26f.1465293714.git.pmatilai@redhat.com> <24422417.UYSFgAybK6@xps13> <20160607140715.GC6948@bricha3-MOBL3> <4901376.7OB1d4j3hA@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christian Ehrhardt , Panu Matilainen , dev@dpdk.org, Ferruh Yigit , olivier.matz@6wind.com To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E07DD9611 for ; Tue, 7 Jun 2016 16:37:58 +0200 (CEST) Content-Disposition: inline In-Reply-To: <4901376.7OB1d4j3hA@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 07, 2016 at 04:19:47PM +0200, Thomas Monjalon wrote: > 2016-06-07 15:07, Bruce Richardson: > > On Tue, Jun 07, 2016 at 03:00:45PM +0200, Thomas Monjalon wrote: > > > 2016-06-07 14:36, Christian Ehrhardt: > > > > But I still struggle to see how to fix the circular dependency between > > > > librte_eal and librte_mempool. > > > > > > Why is there a circular dependency? > > > Only because of logs using mempool? > > > > > > > Maybe now is a time to look at this part of the original threads again to > > > > eventually get apps less overlinked? > > > > => http://www.dpdk.org/ml/archives/dev/2016-May/039441.html > > > > My naive suggestions in generalized form can be found there (no answer yet): > > > > => > > > > http://stackoverflow.com/questions/37351699/how-to-create-both-so-files-for-two-circular-depending-libraries > > > > > > I would prefer removing the circular dependency. > > > Maybe we can rewrite the code to not use mempool or move it outside of EAL. > > > > Or else we can take the attitude that the mempools and the rings are just a core > > part of DPDK and move them and the EAL into a dpdk_core library at link time. > > Having the code separate in the git tree is good, but I'm not sure having > > the resulting object files being in separate .a/.so files is particularly useful. > > I can't see someone wanting to use one without the other. > > EAL could be used as an abstraction layer on top of systems and platforms. > And I think keeping things separated and layered help to maintain a design > easy to understand. All that applies to the code, not so much to the resulting libraries generated. I don't see how having a separate eal.so and mempool.so particularly helps in any way, except to require more flags for linking. /Bruce