From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v4 01/39] bnxt: new driver for Broadcom NetXtreme-C devices Date: Wed, 8 Jun 2016 11:31:30 +0100 Message-ID: <20160608103129.GC11724@bricha3-MOBL3> References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com> <1584764.9XWLYtHf7Q@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Hurd , dev@dpdk.org, ajit.khaparde@broadcom.com To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 441A19602 for ; Wed, 8 Jun 2016 12:31:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1584764.9XWLYtHf7Q@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 07, 2016 at 08:25:44AM +0200, Thomas Monjalon wrote: > Hi Stephen, > Reminder from http://dpdk.org/dev#send: > > git send-email -39 -v4 --cover-letter --annotate > --in-reply-to > > Please do not forget --in-reply-to. Thanks Three other minor style updates as well that would make my life a little easier: * The sign-off type tags at the bottom of the email are kept in logical chronological order (irrespective of actual chronological order). This means that all signed-off-by tags go together followed by a reviewed-by tag afterwards. * Watch out for initial caps at the start of a commit title. [This will be caught by the check-git-log.sh script if you want to run that] * The history updates from vN to vN+1 are best put after the signoffs and prefixed with a cutline, so that they get stripped automatically when the patch is applied. Otherwise I have to delete them manually from the commit message. The format of the messages is therefore best done as: bnxt: <commit message> Signed-off-by: <author1> Signed-off-by: <author2> Reviewed-by: <reviewer1> --- vN changes <description of changes> Thanks, /Bruce