From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 30/39] bnxt: add start/stop/link update
 operations
Date: Wed, 8 Jun 2016 11:41:50 +0100
Message-ID: <20160608104150.GE11724@bricha3-MOBL3>
References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com>
 <1465250923-78695-30-git-send-email-stephen.hurd@broadcom.com>
 <20160608100208.GA11724@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, ajit.khaparde@broadcom.com
To: Stephen Hurd <stephen.hurd@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 073C4AD86
 for <dev@dpdk.org>; Wed,  8 Jun 2016 12:41:59 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160608100208.GA11724@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 08, 2016 at 11:02:08AM +0100, Bruce Richardson wrote:
> On Mon, Jun 06, 2016 at 03:08:34PM -0700, Stephen Hurd wrote:
> > From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> >=20
> > This patch adds code to add the start, stop and link update dev_ops.
> > The BNXT driver will now minimally pass traffic with testpmd.
> >=20
> > v4:
> > - Fix issues pointed out by checkpatch.
> > - Shorten the string passed for reserving memzone
> > when default completion ring is created.
> >=20
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Reviewed-by: David Christensen <david.christensen@broadcom.com>
> > Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> > ---
> >  drivers/net/bnxt/bnxt_ethdev.c | 269 +++++++++++++++++++++++++++++++=
++++++++++
> >  1 file changed, 269 insertions(+)
> >=20
> I get compilation errors after applying this patch:
>=20
> =3D=3D Build drivers/net/bnxt
>   CC bnxt_ethdev.o
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c: In f=
unction =E2=80=98bnxt_init_chip=E2=80=99:
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:135:7=
: error: implicit declaration of function =E2=80=98bnxt_alloc_hwrm_rings=E2=
=80=99 [-Werror=3Dimplicit-function-declaration]
>   rc =3D bnxt_alloc_hwrm_rings(bp);
>        ^
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:135:2=
: error: nested extern declaration of =E2=80=98bnxt_alloc_hwrm_rings=E2=80=
=99 [-Werror=3Dnested-externs]
>   rc =3D bnxt_alloc_hwrm_rings(bp);
>   ^
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c: In f=
unction =E2=80=98bnxt_init_nic=E2=80=99:
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:233:2=
: error: implicit declaration of function =E2=80=98bnxt_init_ring_grps=E2=
=80=99 [-Werror=3Dimplicit-function-declaration]
>   bnxt_init_ring_grps(bp);
>   ^
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:233:2=
: error: nested extern declaration of =E2=80=98bnxt_init_ring_grps=E2=80=99=
 [-Werror=3Dnested-externs]
> cc1: all warnings being treated as errors
> /home/bruce/next-net/dpdk-next-net/mk/internal/rte.compile-pre.mk:126: =
recipe for target 'bnxt_ethdev.o' failed
> make[5]: *** [bnxt_ethdev.o] Error 1
>=20
Please ignore, my mistake, as I was missing patch 28.

/Bruce