From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] mbuf: remove unused Rx error flags Date: Mon, 13 Jun 2016 15:00:16 +0100 Message-ID: <20160613140016.GF15736@bricha3-MOBL3> References: <57344C06.1030007@6wind.com> <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B6FD97@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Olivier Matz , "dev@dpdk.org" , "johndale@cisco.com" , "Zhang, Helin" , "arnon@qwilt.com" , "rolette@infinite.io" , "Chen, Jing D" , "Wu, Jingjing" To: "Ananyev, Konstantin" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DBFCC2C16 for ; Mon, 13 Jun 2016 16:00:21 +0200 (CEST) Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB97725836B6FD97@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 13, 2016 at 12:39:33PM +0000, Ananyev, Konstantin wrote: > > > > -----Original Message----- > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > Sent: Monday, May 23, 2016 8:56 AM > > To: dev@dpdk.org > > Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.com; rolette@infinite.io; Chen, Jing D; Wu, Jingjing > > Subject: [PATCH] mbuf: remove unused Rx error flags > > > > Following the discussions from: > > http://dpdk.org/ml/archives/dev/2015-July/021721.html > > http://dpdk.org/ml/archives/dev/2016-April/038143.html > > > > The value of these flags is 0, making them useless. Today, no example > > application checks them on Rx, and only few drivers sets them and > > silently give wrong packets to the application, which should not happen. > > > > This patch removes the unused flags from rte_mbuf and their use in the > > drivers. The i40e and fm10k are kept as they are today and should be > > fixed to drop bad packets. The enic driver is managed by its maintainer > > in another patch. > > > > Fixes: c22265f6 ("mbuf: add new packet flags for i40e") > > Signed-off-by: Olivier Matz > > --- > > Acked-by: Konstantin Ananyev > Applied to dpdk-next-net/rel_16_07 /Bruce