From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v4 00/19] DPDK PMD for ThunderX NIC device Date: Mon, 13 Jun 2016 16:46:51 +0100 Message-ID: <20160613154650.GJ15736@bricha3-MOBL3> References: <1465317632-11471-2-git-send-email-jerin.jacob@caviumnetworks.com> <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas.monjalon@6wind.com, ferruh.yigit@intel.com To: Jerin Jacob Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2DA38558D for ; Mon, 13 Jun 2016 17:46:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 13, 2016 at 07:25:24PM +0530, Jerin Jacob wrote: > This patch set provides the initial version of DPDK PMD for the > built-in NIC device in Cavium ThunderX SoC family. > > Implemented features and ThunderX nicvf PMD documentation added > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > respectively in this patch set. > > These patches are checked using checkpatch.sh with following > additional ignore option: > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > CAMELCASE - To accommodate PRIx64 > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > Hi Jerin, other than the fact that patch 1 is very big, this set looks pretty ok to me. However, as a general comment on the series: the commit titles are overly low-level, as they refer too much to function/structure names e.g. patches 4 through 10. If you run the script "check-git-log.sh" on your patchset this will be flagged. What is expected in commit titles is that the change introduced by the path is explained without directly using the function names. Regards, /Bruce