From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2 01/15] i40e/base: remove HMC AQ APIs Date: Tue, 14 Jun 2016 11:14:16 +0100 Message-ID: <20160614101416.GA18600@bricha3-MOBL3> References: <1462438424-22574-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-2-git-send-email-helin.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Helin Zhang Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 283DE7E24 for ; Tue, 14 Jun 2016 12:14:20 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1464070989-32726-2-git-send-email-helin.zhang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 24, 2016 at 02:22:55PM +0800, Helin Zhang wrote: > HMC AQ APIs were removed from the latest datasheet, and > hence remove its implementations and relevant. > > Signed-off-by: Helin Zhang Still haven't clarified what HMC stands for.... :-) Looking up an old data sheet, I guess it stands for "Host Memory Cache", is that correct? Please expand out all acronyms in the commit message unless they are really common ones. Regards, /Bruce PS: Suggested rule of thumb - unless it's called out for a capitalization check in scripts/check-git-log.sh, the acronym is not common enough, and you need to expand it out.