From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 04/15] i40e/base: trim the code
Date: Tue, 14 Jun 2016 11:16:33 +0100
Message-ID: <20160614101632.GB18600@bricha3-MOBL3>
References: <1462438424-22574-1-git-send-email-helin.zhang@intel.com>
 <1464070989-32726-1-git-send-email-helin.zhang@intel.com>
 <1464070989-32726-5-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Helin Zhang <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id F39626CCD
 for <dev@dpdk.org>; Tue, 14 Jun 2016 12:16:36 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1464070989-32726-5-git-send-email-helin.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 24, 2016 at 02:22:58PM +0800, Helin Zhang wrote:
> It trim the source code, with limiting pieces of code for
> PF or VF driver only, code style fixes, and annotation
> rewording.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  drivers/net/i40e/base/i40e_adminq.c     | 52 +++++++++++++++++++--------------
>  drivers/net/i40e/base/i40e_adminq.h     |  4 +--
>  drivers/net/i40e/base/i40e_adminq_cmd.h | 21 +++++++------
>  drivers/net/i40e/base/i40e_common.c     |  5 ++--
>  drivers/net/i40e/base/i40e_prototype.h  |  3 +-
>  5 files changed, 48 insertions(+), 37 deletions(-)
> 
The word "trim" generally implies making things shorter, but in this case more
lines are added to the code than deleted. The title should therefore be something
more like "limit PF/VF specific source code to that driver only".

/Bruce