From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v5 00/25] DPDK PMD for ThunderX NIC device
Date: Thu, 16 Jun 2016 15:01:02 +0530
Message-ID: <20160616093059.GA21920@localhost.localdomain>
References: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <20160615143925.GD11536@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bl2-obe.outbound.protection.outlook.com
 (mail-bl2on0096.outbound.protection.outlook.com [65.55.169.96])
 by dpdk.org (Postfix) with ESMTP id C247DC49E
 for <dev@dpdk.org>; Thu, 16 Jun 2016 11:31:27 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160615143925.GD11536@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 15, 2016 at 03:39:25PM +0100, Bruce Richardson wrote:
> On Wed, Jun 15, 2016 at 12:36:15AM +0530, Jerin Jacob wrote:
> > This patch set provides the initial version of DPDK PMD for the
> > built-in NIC device in Cavium ThunderX SoC family.
> > 
> > Implemented features and ThunderX nicvf PMD documentation added
> > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst
> > respectively in this patch set.
> > 
> > These patches are checked using checkpatch.sh with following
> > additional ignore option:
> >     options="$options --ignore=CAMELCASE,BRACKET_SPACE"
> > CAMELCASE - To accommodate PRIx64
> > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places
> > 
> > This patch set is based on DPDK 16.07-RC1
> > and tested with git HEAD change-set
> > ca173a909538a2f1082cd0dcb4d778a97dab69c3 along with
> > following depended patch
> > 
> > http://dpdk.org/dev/patchwork/patch/11826/
> > ethdev: add tunnel and port RSS offload types
> > 
> Hi Jerin,
> 
> hopefully a final set of comments before merge on this set, as it's looking
> very good now.
> 
> * Two patches look like they need to be split, as they are combining multiple
>   functions into one patch. They are:
>     [dpdk-dev,v5,16/25] net/thunderx: add MTU set and promiscuous enable support
>     [dpdk-dev,v5,20/25] net/thunderx: implement supported ptype get and Rx queue count
>   For the other patches which add multiple functions, the functions seem to be
>   logically related so I don't think there is a problem
> 
> * check-git-logs.sh is warning about a few of the commit messages being too long.
>   Splitting patch 20 should fix one of those, but there are a few remaining.
>   A number of titles refer to ThunderX in the message, but this is probably
>   unnecessary, as the prefix already contains "net/thunderx" in it.

OK. I will send the next revision.

> 
> Regards,
> /Bruce
> 
> PS: Please also baseline patches on dpdk-next-net/rel_16_07 tree. They currently
> apply fine to that tree so there is no problem, but just in case later commits
> break things, that is the tree that net patches should be based on.