From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 00/25] DPDK PMD for ThunderX NIC device Date: Thu, 16 Jun 2016 15:33:20 +0100 Message-ID: <20160616143320.GC14984@bricha3-MOBL3> References: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com> <20160615143925.GD11536@bricha3-MOBL3> <20160616093059.GA21920@localhost.localdomain> <20160616105827.GF11016@bricha3-MOBL3> <20160616111737.GA27345@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas.monjalon@6wind.com, ferruh.yigit@intel.com To: Jerin Jacob Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7F604C4E0 for ; Thu, 16 Jun 2016 16:37:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160616111737.GA27345@localhost.localdomain> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 16, 2016 at 04:47:39PM +0530, Jerin Jacob wrote: > On Thu, Jun 16, 2016 at 11:58:27AM +0100, Bruce Richardson wrote: > > On Thu, Jun 16, 2016 at 03:01:02PM +0530, Jerin Jacob wrote: > > > On Wed, Jun 15, 2016 at 03:39:25PM +0100, Bruce Richardson wrote: > > > > On Wed, Jun 15, 2016 at 12:36:15AM +0530, Jerin Jacob wrote: > > > > > This patch set provides the initial version of DPDK PMD for the > > > > > built-in NIC device in Cavium ThunderX SoC family. > > > > > > > > > > Implemented features and ThunderX nicvf PMD documentation added > > > > > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > > > > > respectively in this patch set. > > > > > > > > > > These patches are checked using checkpatch.sh with following > > > > > additional ignore option: > > > > > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > > > > > CAMELCASE - To accommodate PRIx64 > > > > > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > > > > > > > > > > This patch set is based on DPDK 16.07-RC1 > > > > > and tested with git HEAD change-set > > > > > ca173a909538a2f1082cd0dcb4d778a97dab69c3 along with > > > > > following depended patch > > > > > > > > > > http://dpdk.org/dev/patchwork/patch/11826/ > > > > > ethdev: add tunnel and port RSS offload types > > > > > > > > > Hi Jerin, > > > > > > > > hopefully a final set of comments before merge on this set, as it's looking > > > > very good now. > > > > > > > > * Two patches look like they need to be split, as they are combining multiple > > > > functions into one patch. They are: > > > > [dpdk-dev,v5,16/25] net/thunderx: add MTU set and promiscuous enable support > > > > [dpdk-dev,v5,20/25] net/thunderx: implement supported ptype get and Rx queue count > > > > For the other patches which add multiple functions, the functions seem to be > > > > logically related so I don't think there is a problem > > > > > > > > * check-git-logs.sh is warning about a few of the commit messages being too long. > > > > Splitting patch 20 should fix one of those, but there are a few remaining. > > > > A number of titles refer to ThunderX in the message, but this is probably > > > > unnecessary, as the prefix already contains "net/thunderx" in it. > > > > > > OK. I will send the next revision. > > > > > > > Please hold off a few hours, as I'm hoping to merge in the bnxt driver this > > afternoon. If all goes well, I would appreciate it if you could base your patchset > > off the rel_16_07 tree with that set applied - save me having to resolve conflicts > > in files like the nic overview doc, which is always a pain to try and edit. :-) > > OK. I will re-base the changes once you have done with bnxt merge. > Let me know once its done. > Done now. Feel free to submit a new version based on rel_16_07 branch. Thanks, /Bruce