From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH 00/24] Refactor mlx5 to improve performance
Date: Mon, 20 Jun 2016 09:38:54 +0200
Message-ID: <20160620073854.GE14221@autoinstall.dev.6wind.com>
References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com>
 <576420C7.6010301@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id B77029AD9
 for <dev@dpdk.org>; Mon, 20 Jun 2016 09:38:57 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id f126so57184848wma.1
 for <dev@dpdk.org>; Mon, 20 Jun 2016 00:38:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <576420C7.6010301@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 17, 2016 at 05:09:43PM +0100, Ferruh Yigit wrote:
> On 6/8/2016 10:47 AM, Nelio Laranjeiro wrote:
> > Enhance mlx5 with a data path that bypasses Verbs.
> >=20
> > The first half of this patchset removes support for functionality com=
pletely
> > rewritten in the second half (scatter/gather, inline send), while the=
 data
> > path is refactored without Verbs.
> >=20
> > The PMD remains usable during the transition.
> >=20
> > This patchset must be applied after "Miscellaneous fixes for mlx4 and=
 mlx5".
> >=20
> > Adrien Mazarguil (8):
> >   mlx5: replace countdown with threshold for TX completions
> >   mlx5: add debugging information about TX queues capabilities
> >   mlx5: check remaining space while processing TX burst
> >   mlx5: resurrect TX gather support
> >   mlx5: work around spurious compilation errors
> >   mlx5: remove redundant RX queue initialization code
> >   mlx5: make RX queue reinitialization safer
> >   mlx5: resurrect RX scatter support
> >=20
> > Nelio Laranjeiro (15):
> >   mlx5: split memory registration function for better performance
> >   mlx5: remove TX gather support
> >   mlx5: remove RX scatter support
> >   mlx5: remove configuration variable for maximum number of segments
> >   mlx5: remove inline TX support
> >   mlx5: split TX queue structure
> >   mlx5: split RX queue structure
> >   mlx5: update prerequisites for upcoming enhancements
> >   mlx5: add definitions for data path without Verbs
> >   mlx5: add support for configuration through kvargs
> >   mlx5: add TX/RX burst function selection wrapper
> >   mlx5: refactor RX data path
> >   mlx5: refactor TX data path
> >   mlx5: handle RX CQE compression
> >   mlx5: add support for multi-packet send
> >=20
> > Yaacov Hazan (1):
> >   mlx5: add support for inline send
> >=20
>=20
> I run basic checks to the patchset:
>=20
> There are various checkpatch warnings, all are warning or check level
>=20
> Patch 8 and 13 failed to apply with via git, -looks line line numbers
> shifted a little, this is not a problem since eventually it applies but
> just for your information.
>=20
> check-git-log is giving following errors, it is mainly case issue in Rx=
/Tx:
> Wrong headline lowercase:
>         mlx5: resurrect RX scatter support
>         mlx5: make RX queue reinitialization safer
>         mlx5: remove redundant RX queue initialization code
>         mlx5: resurrect TX gather support
>         mlx5: check remaining space while processing TX burst
>         mlx5: add debugging information about TX queues capabilities
>         mlx5: replace countdown with threshold for TX completions
>         mlx5: handle RX CQE compression
>         mlx5: refactor RX data path
>         mlx5: add TX/RX burst function selection wrapper
>         mlx5: split RX queue structure
>         mlx5: split TX queue structure
>         mlx5: remove inline TX support
>         mlx5: remove RX scatter support
>         mlx5: remove TX gather support
> Headline too long:
>         mlx5: remove configuration variable for maximum number of segme=
nts
>         mlx5: split memory registration function for better performance
>=20
>=20
> It compiles fine.
>=20
> Regards,
> ferruh

Hi ferruh,

In fact, It does not apply well on top the current DPDK master branch.

Thanks.

--=20
N=E9lio Laranjeiro
6WIND