From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings Date: Mon, 20 Jun 2016 09:19:40 -0700 Message-ID: <20160620091940.75a37c54@xeon-e3> References: <20160620124435.23d43f28@miho> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, dev@dpdk.org To: Simon Kagstrom Return-path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id 9993B2BAB for ; Mon, 20 Jun 2016 18:19:26 +0200 (CEST) Received: by mail-pa0-f49.google.com with SMTP id wo6so15895825pac.3 for ; Mon, 20 Jun 2016 09:19:26 -0700 (PDT) In-Reply-To: <20160620124435.23d43f28@miho> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 20 Jun 2016 12:44:35 +0200 Simon Kagstrom wrote: > I.e., avoid dump messages with double 0x0x, e.g., > > dump mbuf at 0x0x7fac7b17c800, phys=17b17c880, buf_len=2176 > pkt_len=2064, ol_flags=0, nb_segs=1, in_port=255 > segment at 0x0x7fac7b17c800, data=0x0x7fac7b17c8f0, data_len=2064 > > Signed-off-by: Simon Kagstrom Agreed. Many other places have same glitch. $ git grep '0x%p' drivers/net/vmxnet3/vmxnet3_rxtx.c: "RXQ: cmd0 base : 0x%p cmd1 base : 0x%p comp ring base : 0x%p.", drivers/net/vmxnet3/vmxnet3_rxtx.c: PMD_TX_LOG(DEBUG, "TXQ: cmd base : 0x%p comp ring base : 0x%p data ring base : 0x%p.", lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c: printk(KERN_DEBUG "ixgbe_get_regs_2 0x%p\n", hw->hw_addr); lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("tx_phys: 0x%016llx, tx_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("rx_phys: 0x%016llx, rx_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("alloc_phys: 0x%016llx, alloc_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("free_phys: 0x%016llx, free_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("req_phys: 0x%016llx, req_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("resp_phys: 0x%016llx, resp_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("mbuf_phys: 0x%016llx, mbuf_kva: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("mbuf_va: 0x%p\n", dev_info.mbuf_va); lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_DBG("PCI found: pci=0x%p, lad_dev=0x%p\n", lib/librte_mbuf/rte_mbuf.c: fprintf(f, "dump mbuf at 0x%p, phys=%"PRIx64", buf_len=%u\n", lib/librte_mbuf/rte_mbuf.c: fprintf(f, " segment at 0x%p, data=0x%p, data_len=%u\n",