From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH] mlx: fix compilation with older Glibc
Date: Mon, 20 Jun 2016 11:25:18 +0200
Message-ID: <20160620092518.GT7621@6wind.com>
References: <1465571372-28254-1-git-send-email-adrien.mazarguil@6wind.com>
 <1465896120-17173-1-git-send-email-adrien.mazarguil@6wind.com>
 <57642581.8070704@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 7861F9616
 for <dev@dpdk.org>; Mon, 20 Jun 2016 11:25:24 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id r201so52551072wme.1
 for <dev@dpdk.org>; Mon, 20 Jun 2016 02:25:24 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <57642581.8070704@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 17, 2016 at 05:29:53PM +0100, Ferruh Yigit wrote:
> On 6/14/2016 10:22 AM, Adrien Mazarguil wrote:
> > A missing define in the previous patch causes additional compilation
> > issues.
> > 
> > Fixes: 3025206f5060 ("mlx: fix compilation with recent Glibc")
> > 
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> "older Glibc" or "recent Glibc" can be very hard to trace from git
> history later.

I wasn't sure about the exact version, it appears to be 2.19 and/or 2.20,
where _BSD_SOURCE was modified and subsequently removed.

I suggest squashing this patch into the original broken commit ("mlx: fix
compilation with recent Glibc") if possible, I did not submit a v2 as it is
already applied on dpdk-next-net.

> Does it make sense to add glibc version info for the failing ones or
> fixed one?

Depends if we can modify the first commit. If we do, let's squash them
together before adding version information, otherwise let's modify the
second one only.

I can submit a v2 that overrides both commits or only the second one, tell
me what you think is best.

-- 
Adrien Mazarguil
6WIND