From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 15/30] ixgbe/base: refactor NW management interface ops Date: Tue, 21 Jun 2016 17:19:48 +0100 Message-ID: <20160621161948.GA10676@bricha3-MOBL3> References: <1465887596-10346-1-git-send-email-beilei.xing@intel.com> <1465977220-3970-1-git-send-email-beilei.xing@intel.com> <1465977220-3970-16-git-send-email-beilei.xing@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: wenzhuo.lu@intel.com, dev@dpdk.org To: Beilei Xing Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DC727C12E for ; Tue, 21 Jun 2016 18:19:52 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1465977220-3970-16-git-send-email-beilei.xing@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 15, 2016 at 03:53:25PM +0800, Beilei Xing wrote: > This patch adds ixgbe_read_mng_if_sel_x550em to read NW_MNG_IF_SEL > register and save fields such as PHY MDIO_ADD. > > Signed-off-by: Beilei Xing NW == "network" or something else? Please expand the acronym. Also, this commit message is describing what is happening in the changes in the patch, but it doesn't give any details as to why. Can this message be expanded to give more details on the reason for change. Thanks, /Bruce