From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 1/2] ethdev: add tunnel and port RSS
 offload types
Date: Wed, 22 Jun 2016 22:18:50 +0530
Message-ID: <20160622164849.GA3303@localhost.localdomain>
References: <1459371063-7376-2-git-send-email-jerin.jacob@caviumnetworks.com>
 <1466600601-27682-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1466600601-27682-2-git-send-email-jerin.jacob@caviumnetworks.com>
 <2167044.sXmK8V57pq@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1on0086.outbound.protection.outlook.com [157.56.110.86])
 by dpdk.org (Postfix) with ESMTP id 9547FBDC2
 for <dev@dpdk.org>; Wed, 22 Jun 2016 18:49:18 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <2167044.sXmK8V57pq@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 22, 2016 at 05:06:30PM +0200, Thomas Monjalon wrote:
> 2016-06-22 18:33, Jerin Jacob:
> > - added VXLAN, GENEVE and NVGRE tunnel flow types
> > - added PORT flow type for accounting physical/virtual
> > port or channel number in flow creation
> [...]
> > +#define RTE_ETH_FLOW_PORT               18
> > +	/**< Physical/virtual port number based flow */
> 
> What about
> "Consider device port number as a flow differentiator" ?
> 
> I can make the change if you (Jerin and/or Bruce) agree.

Looks OK to me. No strong opinion on this.