From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 0/6] ena: update PMD to cooperate with
 latest ENA firmware
Date: Fri, 24 Jun 2016 12:52:39 +0100
Message-ID: <20160624115239.GI13456@bricha3-MOBL3>
References: <1466099690-28085-1-git-send-email-jan@semihalf.com>
 <1466510763-19569-1-git-send-email-jan@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Jan Medala <jan@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id DB11BC44A
 for <dev@dpdk.org>; Fri, 24 Jun 2016 13:53:38 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1466510763-19569-1-git-send-email-jan@semihalf.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 21, 2016 at 02:05:57PM +0200, Jan Medala wrote:
> As requested, big patch splitted into logical pieces for easier review.
> Improved style and fixed icc compiler issues.
> 

Thanks for the patch split. However, many of the patches don't have a commit
message describing (at a high level), what the goal of that patch is and how
it goes about implementing the changes to achieve that goal. Can you add a
paragraph or two of commit message to each patch on the set to help anyone
looking at the code understand what is happening in each patch.

Regards,
/Bruce

> Jan Medala (6):
>   ena: update of ENA communication layer
>   ena: add debug area and host information
>   ena: disable readless communication regarding to HW revision
>   ena: allocate coherent memory in node-aware way
>   ena: fix memory management issue
>   ena: fix for icc compiler
> 
>  drivers/net/ena/base/ena_com.c                  | 254 +++++++-------
>  drivers/net/ena/base/ena_com.h                  |  82 +++--
>  drivers/net/ena/base/ena_defs/ena_admin_defs.h  | 107 +-----
>  drivers/net/ena/base/ena_defs/ena_eth_io_defs.h | 436 ++++++------------------
>  drivers/net/ena/base/ena_defs/ena_gen_info.h    |   4 +-
>  drivers/net/ena/base/ena_eth_com.c              |  32 +-
>  drivers/net/ena/base/ena_eth_com.h              |  14 +
>  drivers/net/ena/base/ena_plat_dpdk.h            |  42 ++-
>  drivers/net/ena/ena_ethdev.c                    | 275 ++++++++++++++-
>  drivers/net/ena/ena_ethdev.h                    |  40 +++
>  10 files changed, 675 insertions(+), 611 deletions(-)
> 
> -- 
> 2.8.2
>