From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v7 22/25] mlx5: work around spurious
	compilation errors
Date: Mon, 27 Jun 2016 14:27:29 +0200
Message-ID: <20160627122729.GR7621@6wind.com>
References: <1466758261-25986-1-git-send-email-nelio.laranjeiro@6wind.com>
 <1466774284-20932-1-git-send-email-nelio.laranjeiro@6wind.com>
 <1466774284-20932-23-git-send-email-nelio.laranjeiro@6wind.com>
 <20160627121215.GA15684@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id B93545939
 for <dev@dpdk.org>; Mon, 27 Jun 2016 14:27:31 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id v199so98080065wmv.0
 for <dev@dpdk.org>; Mon, 27 Jun 2016 05:27:31 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20160627121215.GA15684@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jun 27, 2016 at 01:12:15PM +0100, Bruce Richardson wrote:
> On Fri, Jun 24, 2016 at 03:18:01PM +0200, Nelio Laranjeiro wrote:
> > From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > 
> > Since commit "mlx5: resurrect Tx gather support", older GCC versions (such
> > as 4.8.5) may complain about the following:
> > 
> >  mlx5_rxtx.c: In function `mlx5_tx_burst':
> >  mlx5_rxtx.c:705:25: error: `wqe' may be used uninitialized in this
> >      function [-Werror=maybe-uninitialized]
> > 
> >  mlx5_rxtx.c: In function `mlx5_tx_burst_inline':
> >  mlx5_rxtx.c:864:25: error: `wqe' may be used uninitialized in this
> >      function [-Werror=maybe-uninitialized]
> > 
> > In both cases, this code cannot be reached when wqe is not initialized.
> > 
> > Considering older GCC versions are still widely used, work around this
> > issue by initializing wqe preemptively, even if it should not be necessary.
> > 
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> Since the previous patch is known to break the build on older compilers, I think
> it would be better to merge this patch into the previous to prevent the break
> from occurring in the first place. That will help with any future git-bisects
> that people run.

Makes sense, in fact I only kept it separate to decribe why setting these
variables was necessary, in case someone wondered.

> If there is no objection, and no other issues appear requiring a new rev of
> this patchset, I'll merge patches 21 and 22 on apply.

That's fine by me.

-- 
Adrien Mazarguil
6WIND